Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make MonoidK[Endo] stack safe on combineK #2760

Merged
merged 1 commit into from
Mar 26, 2019
Merged

Make MonoidK[Endo] stack safe on combineK #2760

merged 1 commit into from
Mar 26, 2019

Conversation

denisrosca
Copy link
Contributor

Closes #2738

@codecov-io
Copy link

Codecov Report

Merging #2760 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2760      +/-   ##
==========================================
+ Coverage   95.34%   95.34%   +<.01%     
==========================================
  Files         363      363              
  Lines        6782     6785       +3     
  Branches      290      287       -3     
==========================================
+ Hits         6466     6469       +3     
  Misses        316      316
Impacted Files Coverage Δ
core/src/main/scala/cats/instances/function.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 103a698...8639d37. Read the comment docs.

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #2760 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2760      +/-   ##
==========================================
+ Coverage   95.34%   95.34%   +<.01%     
==========================================
  Files         363      363              
  Lines        6782     6785       +3     
  Branches      290      287       -3     
==========================================
+ Hits         6466     6469       +3     
  Misses        316      316
Impacted Files Coverage Δ
core/src/main/scala/cats/instances/function.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 103a698...8639d37. Read the comment docs.

LukaJCB
LukaJCB approved these changes Mar 26, 2019
View reviewed changes
Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

kailuowang
kailuowang approved these changes Mar 26, 2019
View reviewed changes
Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks!

@kailuowang kailuowang merged commit 8d42f24 into typelevel:master Mar 26, 2019
@kailuowang kailuowang added this to the 2.0 milestone Mar 26, 2019
@adrian-salajan
Copy link

Thanks!

@fbunau
Copy link

fbunau commented Mar 26, 2019

woot, thanks man!

@rossabaker rossabaker mentioned this pull request May 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaJCB LukaJCB LukaJCB approved these changes

@kailuowang kailuowang kailuowang approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.0.0-M1
Development

Successfully merging this pull request may close these issues.
6 participants
@denisrosca @codecov-io @adrian-salajan @fbunau @kailuowang @LukaJCB