[WIP] move to Scala 2.13.0-RC1 (drop -M5) #2783
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jozic
reviewed
Apr 11, 2019
| @@ -82,7 +82,7 @@ trait ApplicativeError[F[_], E] extends Applicative[F] { | |||
| * `F[A]` values. | |||
| */ | |||
| def recover[A](fa: F[A])(pf: PartialFunction[E, A]): F[A] = | |||
| handleErrorWith(fa)(e => (pf.andThen(pure)).applyOrElse(e, raiseError)) | |||
| handleErrorWith(fa)(e => (pf.andThen(pure _)).applyOrElse(e, raiseError _)) | |||
There was a problem hiding this comment.
may i ask why those underscores are needed now? What have changed to make them required?
There was a problem hiding this comment.
I think it's scala/scala#7263
Merged
|
superseded by #2792 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is just a sketch to get the ball rolling, I don't intend
to finish it myself
not even sure if it's to the right branch, not sure what the plan is around ScalaCheck 1.14.0 being the only ScalaCheck available for 2.13 (for now? not sure if anyone has tried to push for 1.13.x release on 2.13)