-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove catalysts dependency #2791
Remove catalysts dependency #2791
Conversation
Thanks so much for taking on this. I believe this is the right thing to do. |
one less thing to worry about 👍 |
I ran |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks @travisbrown 👍
I am on my phone, the code changes look good to me, but GitHub didn't really show the full path of the rename, so it appears that there is no actual path change. I am curious what they are. |
replaced by #2792 |
@travisbrown I spoke too soon in #2792, there is a conflict and can't be resolved throught github ui. Would it be too much to ask you to resolve it? |
@kailuowang Merged, thanks. |
The catalysts dependency has proven to be a drag on every update (right now it seems to be blocking a release for 2.13.0-RC1) and at this point it's almost completely unused, so I'm proposing that we just scrap it.
There's some dead code in
LawTests
that uses catalysts'sTypeTagM
, but it is unused and hasn't been touched since 2016, so I just scrapped it. Otherwise the only thing catalysts is used for is to check whether the current build is Scala.js in order to set appropriate test sizes.In my view this really should be done with separate code trees, but to keep this PR simple I just introduced a new (package private)
cats.platform.Platform
that duplicates the ~dozen lines of code Cats needs from catalysts.MiMa says this change is fine, all tests pass as usual with no changes (apart from the
Platform
import), etc.r? @SethTisue @kailuowang