Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repetition in NonEmptyChain scala docs #2803

Merged

Conversation

Obarros
Copy link
Contributor

@Obarros Obarros commented Apr 21, 2019

This will update the scaladocs for NonEmptyChain.
The same example was used for reduceRightTo and reduceLeftTo method.
Fix #2803

@codecov-io
Copy link

codecov-io commented Apr 21, 2019

Codecov Report

Merging #2803 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2803   +/-   ##
=======================================
  Coverage   94.15%   94.15%           
=======================================
  Files         368      368           
  Lines        6914     6914           
  Branches      296      296           
=======================================
  Hits         6510     6510           
  Misses        404      404
Impacted Files Coverage Δ
core/src/main/scala/cats/data/NonEmptyChain.scala 98.14% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b562a8...3ec8426. Read the comment docs.

Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks Ozias :)

Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was puzzled how the original example worked. Then I realized that it's the any2stringadd

@kailuowang kailuowang merged commit 16a38cb into typelevel:master Apr 22, 2019
@kailuowang kailuowang added this to the 2.0.0-M1 milestone Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants