Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LowerBounded and UpperBounded typeclasses #2913

Merged

Conversation

izeigerman
Copy link
Contributor

Implements #1536
This is implementation of the 1st step suggested by @kailuowang in #2910 (comment) .
Instances for the following types will be added in a follow-up PR and merged once the 2.11 support is dropped in the master branch: all Tuples, Option, Either, List, Queue, Set, Stream/LazyList, Vector
CC: @LukaJCB

@codecov-io
Copy link

codecov-io commented Jun 26, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@207bb0d). Click here to learn what that means.
The diff coverage is 96.55%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2913   +/-   ##
=========================================
  Coverage          ?   94.24%           
=========================================
  Files             ?      367           
  Lines             ?     6998           
  Branches          ?      198           
=========================================
  Hits              ?     6595           
  Misses            ?      403           
  Partials          ?        0
Impacted Files Coverage Δ
kernel/src/main/scala/cats/kernel/Bounded.scala 0% <0%> (ø)
...cala/cats/kernel/instances/DurationInstances.scala 100% <100%> (ø)
.../src/main/scala/cats/kernel/laws/BoundedLaws.scala 100% <100%> (ø)
.../scala/cats/kernel/instances/StringInstances.scala 100% <100%> (ø)
.../scala/cats/kernel/instances/SymbolInstances.scala 100% <100%> (ø)
core/src/main/scala/cats/data/Const.scala 100% <100%> (ø)
...ats/kernel/instances/FiniteDurationInstances.scala 100% <100%> (ø)
...in/scala/cats/kernel/instances/UnitInstances.scala 100% <100%> (ø)
...in/scala/cats/kernel/instances/UUIDInstances.scala 100% <100%> (ø)
...ain/scala/cats/kernel/instances/IntInstances.scala 100% <100%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 207bb0d...40d7f07. Read the comment docs.

Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks so much!

@kailuowang kailuowang merged commit 22a8cc6 into typelevel:master Jun 27, 2019
@izeigerman izeigerman deleted the iaroslav/bounded-type-class-only branch June 28, 2019 15:29
@LukaJCB LukaJCB mentioned this pull request Jul 3, 2019
@kailuowang kailuowang added this to the 2.0.0-RC1 milestone Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants