Swap order of G[_] and A in Applicative.sequence #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes typelevel#285. Scalaz has a style convention that kinds always go before types in method signatures. Should we adopt the same convention?
|
Before this change: scala> listInstance.sequence[Option, Int](List(Option(1),Option(3)))
<console>:14: error: Int takes no type parameters, expected: one
listInstance.sequence[Option, Int](List(Option(1),Option(3)))After this change: scala> listInstance.sequence[Option, Int](List(Option(1),Option(3)))
res0: Option[List[Int]] = Some(List(1, 3)) |
|
👍 |
|
Do you know if we have been consistent in other places about the order of type parameters? I give this PR 👍 but it would be a shame if we've used this other order elsewhere. |
|
After a bit of investigation I think it's safe to just merge this now. |
non
added a commit
that referenced
this pull request
Apr 27, 2015
Swap order of G[_] and A in Applicative.sequence
ceedubs
added a commit
to ceedubs/cats
that referenced
this pull request
Nov 4, 2015
This is a delayed follow up to typelevel#292 which sets a precedent of a preference for higher-kinded types coming first in type parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #285.
Scalaz has a style convention that kinds always go before types in
method signatures. Should we adopt the same convention?