Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add map to NonEmptyChain. #2939

Merged
merged 3 commits into from
Jul 22, 2019
Merged

add map to NonEmptyChain. #2939

merged 3 commits into from
Jul 22, 2019

Conversation

takayahilton
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Jul 12, 2019 •
edited
Loading

Codecov Report

Merging #2939 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2939      +/-   ##
==========================================
- Coverage   93.91%   93.89%   -0.02%     
==========================================
  Files         371      371              
  Lines        7047     7048       +1     
  Branches      178      177       -1     
==========================================
  Hits         6618     6618              
- Misses        429      430       +1
Impacted Files Coverage Δ
core/src/main/scala/cats/data/NonEmptyChain.scala 82.35% <0%> (-0.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e94169...621625b. Read the comment docs.

kailuowang
kailuowang previously approved these changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kailuowang kailuowang requested a review from LukaJCB July 20, 2019 16:44
@kailuowang
Re-merge
621625b 
the `map` method is provided by the `Functor` instance of `Chain`
kailuowang
kailuowang approved these changes Jul 20, 2019
View reviewed changes
Copy link
Contributor

@kailuowang kailuowang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, this map method is also provided by Functor syntax

@kailuowang kailuowang merged commit c313eb0 into typelevel:master Jul 22, 2019
@takayahilton takayahilton deleted the add-map-to-NonEmptyChain branch July 22, 2019 11:09
@kailuowang kailuowang added this to the 2.0.0-RC1 milestone Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaJCB LukaJCB LukaJCB approved these changes

@kailuowang kailuowang kailuowang approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.0.0-RC1
Development

Successfully merging this pull request may close these issues.
4 participants
@takayahilton @codecov-io @kailuowang @LukaJCB