Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add back mistakenly removed overrides #2957

Merged
merged 2 commits into from
Jul 23, 2019
Merged

add back mistakenly removed overrides #2957

merged 2 commits into from
Jul 23, 2019

Conversation

kailuowang
Copy link
Contributor

@kailuowang kailuowang commented Jul 20, 2019

mistakenly removed by #2941

These performance overrides were mistakenly removed by #2941
@kailuowang kailuowang added this to the 2.0.0-RC1 milestone Jul 20, 2019
@kailuowang kailuowang requested a review from tpolecat July 20, 2019 21:18
@codecov-io
Copy link

Codecov Report

Merging #2957 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2957      +/-   ##
==========================================
+ Coverage   93.91%   93.94%   +0.03%     
==========================================
  Files         371      371              
  Lines        7047     7050       +3     
  Branches      178      183       +5     
==========================================
+ Hits         6618     6623       +5     
+ Misses        429      427       -2
Impacted Files Coverage Δ
core/src/main/scala/cats/data/NonEmptyChain.scala 86.2% <100%> (+2.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e94169...7a18b69. Read the comment docs.

@djspiewak djspiewak merged commit 3f3c979 into master Jul 23, 2019
@LukaJCB LukaJCB deleted the kailuowang-patch-1 branch July 23, 2019 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants