Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add :== unapply to Chain. #2996

Merged
merged 2 commits into from
Aug 20, 2019
Merged

Add :== unapply to Chain. #2996

merged 2 commits into from
Aug 20, 2019

Conversation

takayahilton
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Aug 20, 2019 •
edited
Loading

Codecov Report

Merging #2996 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2996      +/-   ##
==========================================
+ Coverage   93.83%   93.83%   +<.01%     
==========================================
  Files         369      369              
  Lines        7072     7073       +1     
  Branches      195      190       -5     
==========================================
+ Hits         6636     6637       +1     
  Misses        436      436
Impacted Files Coverage Δ
core/src/main/scala/cats/data/Chain.scala 99.65% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 241a7b9...23908b7. Read the comment docs.

kailuowang
kailuowang approved these changes Aug 20, 2019
View reviewed changes
Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

LukaJCB
LukaJCB approved these changes Aug 20, 2019
View reviewed changes
Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this is great :)

@kailuowang kailuowang merged commit 48c8b34 into typelevel:master Aug 20, 2019
@takayahilton takayahilton deleted the add-initlast-unapply-chain branch August 21, 2019 05:04
@travisbrown travisbrown added this to the 2.0-RC2 milestone Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaJCB LukaJCB LukaJCB approved these changes

@kailuowang kailuowang kailuowang approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.0-RC2
Development

Successfully merging this pull request may close these issues.
5 participants
@takayahilton @codecov-io @kailuowang @LukaJCB @travisbrown