-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move appropriate SortedSet and SortedMap instances to kernel #3001
Move appropriate SortedSet and SortedMap instances to kernel #3001
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3001 +/- ##
=========================================
- Coverage 93.75% 93.6% -0.15%
=========================================
Files 366 368 +2
Lines 6935 6948 +13
Branches 185 188 +3
=========================================
+ Hits 6502 6504 +2
- Misses 433 444 +11
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I still hope that we could avoid the bincompat traits by waiting for the branch, but not strongly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, Travis.
* Update alleycats-core, cats-core, cats-free, ... to 2.0.0-RC2 * add cats sortedMap instance import typelevel/cats#3001
I'm splitting out some of the less controversial parts of #3000 so they're not blocked by the name fixes (which I still think should happen before 3.0, even if not in 2.0).
These instances for
SortedMap
andSortedSet
clearly belong in cats-kernel, and while there's some overhead involved in moving them and maintaining bincompat, in this case I think it's hard to argue that it's not worth it—this isn't fixing typos, it's makingimport cats.kernel.instances.all._
do the obviously correct thing.