Make bincompat and prioritization traits package-private #3003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov Report
@@ Coverage Diff @@
## master #3003 +/- ##
=======================================
Coverage 93.75% 93.75%
=======================================
Files 366 366
Lines 6935 6935
Branches 185 185
=======================================
Hits 6502 6502
Misses 433 433
Continue to review full report at Codecov.
|
|
@kailuowang Does this look okay to you? |
kailuowang
approved these changes
Aug 23, 2019
|
Thanks! Will fix conflicts in the other two PRs. |
This was referenced Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One last piece of #3000 that shouldn't be controversial. This change makes all bincompat and prioritization traits (or classes, in a few cases) private to the smallest possible enclosing package.
This is a source-incompatible change, but it's verified to be binary compatible, and there's no good reason for anyone to use these traits explicitly.