Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check bincompat on stuff we should be checking bincompat for #3129

Merged
merged 4 commits into from
Nov 7, 2019

Conversation

travisbrown
Copy link
Contributor

Fixes #3109. I've also added bincompat checking (currently against 2.0.0 only) for cats-laws, cats-kernel-laws, cats-testkit, alleycats-core, and alleycats-laws.

One piece of breakage slipped into the 2.13 build in #3099. I've verified that Travis CI fails with just the first two commits.

@travisbrown travisbrown added this to the 2.1.0-RC1 milestone Nov 6, 2019
Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks very much! assuming build goes green

@travisbrown
Copy link
Contributor Author

(As a side note, you can check this with show mimaPreviousArtifacts, and the results now look reasonable to me, on both 2.12 and 2.13.)

@codecov-io
Copy link

Codecov Report

Merging #3129 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3129   +/-   ##
=======================================
  Coverage   93.19%   93.19%           
=======================================
  Files         376      376           
  Lines        7323     7323           
  Branches      190      190           
=======================================
  Hits         6825     6825           
  Misses        498      498
Flag Coverage Δ
#scala_version_212 93.53% <ø> (ø) ⬆️
#scala_version_213 90.84% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a6d2c3...7b4fb0c. Read the comment docs.

@travisbrown travisbrown merged commit 7fb1327 into typelevel:master Nov 7, 2019
@travisbrown travisbrown deleted the topic/fix-bincompat branch November 7, 2019 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Binary compatibility tests for scala 2.13
7 participants