-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check bincompat on stuff we should be checking bincompat for #3129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks very much! assuming build goes green
(As a side note, you can check this with |
Codecov Report
@@ Coverage Diff @@
## master #3129 +/- ##
=======================================
Coverage 93.19% 93.19%
=======================================
Files 376 376
Lines 7323 7323
Branches 190 190
=======================================
Hits 6825 6825
Misses 498 498
Continue to review full report at Codecov.
|
Fixes #3109. I've also added bincompat checking (currently against 2.0.0 only) for cats-laws, cats-kernel-laws, cats-testkit, alleycats-core, and alleycats-laws.
One piece of breakage slipped into the 2.13 build in #3099. I've verified that Travis CI fails with just the first two commits.