Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unusual kind-projector syntax #3186

Merged
merged 2 commits into from
Dec 10, 2019

Conversation

travisbrown
Copy link
Contributor

Another Dotty-motivated change. These are the only two places we use kind-projector's *[_] syntax, which I personally find pretty unreadable, and I think in both cases writing out the context bounds is a big improvement.

@codecov-io
Copy link

codecov-io commented Dec 3, 2019

Codecov Report

Merging #3186 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3186      +/-   ##
==========================================
- Coverage   92.99%   92.99%   -0.01%     
==========================================
  Files         376      376              
  Lines        7381     7380       -1     
  Branches      195      216      +21     
==========================================
- Hits         6864     6863       -1     
  Misses        517      517
Flag Coverage Δ
#scala_version_212 93.32% <ø> (-0.01%) ⬇️
#scala_version_213 90.53% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
core/src/main/scala/cats/data/Nested.scala 95.06% <ø> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8253462...109adfb. Read the comment docs.

@LukaJCB LukaJCB merged commit 2d7298c into typelevel:master Dec 10, 2019
@travisbrown travisbrown added this to the 2.1.0-RC3 milestone Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants