Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename rangeE for clarity #3198

Merged
merged 1 commit into from
Dec 10, 2019

Conversation

travisbrown
Copy link
Contributor

This is one small thing that I just noticed in #3150, but I'd already caused enough trouble there so I decided it'd be best to handle in a follow-up. 😄

I think rangeE was named to match range, but it doesn't actually create a range, and it's not in any way Either specific, so I replaced it with a general fromValues method that can be used in these tests.

@codecov-io
Copy link

codecov-io commented Dec 10, 2019

Codecov Report

Merging #3198 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3198   +/-   ##
=======================================
  Coverage   93.06%   93.06%           
=======================================
  Files         376      376           
  Lines        7409     7409           
  Branches      196      196           
=======================================
  Hits         6895     6895           
  Misses        514      514
Flag Coverage Δ
#scala_version_212 93.39% <ø> (ø) ⬆️
#scala_version_213 92.83% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70c9625...a915d80. Read the comment docs.

@LukaJCB LukaJCB merged commit 1d9ada4 into typelevel:master Dec 10, 2019
@travisbrown travisbrown added this to the 2.1.0-RC3 milestone Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants