Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc examples for Ior.map #3314

Merged
merged 1 commit into from
Feb 23, 2020

Conversation

ybasket
Copy link
Contributor

@ybasket ybasket commented Feb 22, 2020

Ior.map had just the copy&pasted examples from Ior.bimap, this PR replaces them with proper, equivalent examples for map.

@codecov-io
Copy link

codecov-io commented Feb 22, 2020

Codecov Report

Merging #3314 into master will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3314      +/-   ##
==========================================
+ Coverage    93.2%   93.41%   +0.21%     
==========================================
  Files         377      378       +1     
  Lines        7604     7629      +25     
  Branches      199      222      +23     
==========================================
+ Hits         7087     7127      +40     
+ Misses        517      502      -15
Flag Coverage Δ
#scala_version_212 93.49% <ø> (?)
#scala_version_213 93.2% <ø> (ø) ⬆️
Impacted Files Coverage Δ
core/src/main/scala/cats/data/Ior.scala 98.52% <ø> (+0.03%) ⬆️
core/src/main/scala/cats/Show.scala 100% <0%> (ø) ⬆️
core/src/main/scala/cats/instances/tuple.scala 100% <0%> (ø) ⬆️
core/src/main/scala/cats/data/Const.scala 100% <0%> (ø) ⬆️
core/src/main/scala/cats/data/Validated.scala 100% <0%> (ø) ⬆️
...cala-2.12/cats/kernel/compat/TraversableOnce.scala 0% <0%> (ø)
core/src/main/scala/cats/data/NonEmptyList.scala 98.73% <0%> (+0.01%) ⬆️
core/src/main/scala/cats/data/NonEmptyVector.scala 99.25% <0%> (+0.01%) ⬆️
core/src/main/scala/cats/data/NonEmptySet.scala 97.64% <0%> (+0.02%) ⬆️
core/src/main/scala/cats/instances/option.scala 98.3% <0%> (+0.02%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ede81e...9d5af21. Read the comment docs.

Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@travisbrown travisbrown self-requested a review February 23, 2020 13:58
@travisbrown travisbrown added this to the 2.2.0-M1 milestone Feb 23, 2020
Copy link
Contributor

@travisbrown travisbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@travisbrown travisbrown merged commit 3c1e41a into typelevel:master Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants