Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scalafmt-core to 2.4.2 #3315

Closed

Conversation

scala-steward
Copy link
Contributor

Updates org.scalameta:scalafmt-core from 2.3.2 to 2.4.2.
GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Have a fantastic day writing Scala!

Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

labels: library-update, semver-minor

@fthomas fthomas dismissed a stale review via debf16e February 24, 2020 19:41
@codecov-io
Copy link

Codecov Report

Merging #3315 into master will increase coverage by 0.2%.
The diff coverage is 95.65%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3315     +/-   ##
========================================
+ Coverage    93.2%   93.4%   +0.2%     
========================================
  Files         377     378      +1     
  Lines        7604    7539     -65     
  Branches      199     225     +26     
========================================
- Hits         7087    7042     -45     
+ Misses        517     497     -20
Flag Coverage Δ
#scala_version_212 93.48% <95.4%> (?)
#scala_version_213 93.18% <95.65%> (-0.02%) ⬇️
Impacted Files Coverage Δ
...ore/src/main/scala/alleycats/syntax/foldable.scala 0% <0%> (ø) ⬆️
laws/src/main/scala/cats/laws/discipline/Eq.scala 34.37% <0%> (+1.53%) ⬆️
core/src/main/scala/cats/instances/queue.scala 100% <100%> (ø) ⬆️
laws/src/main/scala/cats/laws/FlatMapLaws.scala 100% <100%> (ø) ⬆️
core/src/main/scala/cats/Monad.scala 95.83% <100%> (-0.47%) ⬇️
...src/main/scala-2.13+/cats/instances/lazyList.scala 100% <100%> (ø) ⬆️
core/src/main/scala/cats/data/Chain.scala 98.46% <100%> (-0.02%) ⬇️
core/src/main/scala/cats/data/NonEmptyChain.scala 92.92% <100%> (ø) ⬆️
core/src/main/scala/cats/Eval.scala 98.82% <100%> (-0.02%) ⬇️
core/src/main/scala/cats/instances/function.scala 100% <100%> (ø) ⬆️
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ede81e...debf16e. Read the comment docs.

@travisbrown
Copy link
Contributor

I'm weakly 👎 on this. Personally I don't mind the {}-to() change in general, except for a few things like Either.catchNonFatal { ... }, and especially forAll { ... } in tests, and to my eye those changes really hurt readability. My vote would be we change the config to avoid that particular rewrite.

@travisbrown
Copy link
Contributor

Superseded by #3337.

@travisbrown travisbrown closed this Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants