Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate @johnynek's intercalate optimization from #3279 #3321

Closed

Conversation

travisbrown
Copy link
Contributor

This is a minor thing but I'm opening this PR so we don't lose track of it.

@johnynek originally included this optimization in #3279, but removed it because prior to #3303 combine for BigDecimal wasn't actually commutative on Scala 2.13. That's fixed now, so we can put this back.

@codecov-io
Copy link

Codecov Report

Merging #3321 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3321      +/-   ##
==========================================
+ Coverage   93.31%   93.31%   +<.01%     
==========================================
  Files         378      378              
  Lines        7684     7686       +2     
  Branches      233      222      -11     
==========================================
+ Hits         7170     7172       +2     
  Misses        514      514
Flag Coverage Δ
#scala_version_212 93.38% <100%> (ø) ⬆️
#scala_version_213 93.09% <100%> (ø) ⬆️
Impacted Files Coverage Δ
.../main/scala/cats/kernel/CommutativeSemigroup.scala 66.66% <100%> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e12f4d...4b643d8. Read the comment docs.

@travisbrown
Copy link
Contributor Author

This commit is merged but for some reason the PR didn't close itself. I'm leaving it open for now in the hopes that the issue will resolve itself (and keep our PR history accurate), but please don't merge again.

scala-steward pushed a commit to scala-steward/cats that referenced this pull request Feb 27, 2020
@travisbrown travisbrown added this to the 2.2.0-M1 milestone Feb 29, 2020
@travisbrown travisbrown modified the milestone: 2.2.0-M1 Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants