Specific commutativity and associativity tests for BigDecimal #3325
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the fix in #3303 we were seeing occasional failed tests on Scala 2.13, and we haven't seen any since then, but I should have added some tests that specifically highlighted the fix, to make sure the instance don't accidentally get changed back, etc.
In this PR I've added two specific cases where commutativity and associativity didn't hold for the old
|+|
forBigDecimal
on Scala 2.13, which simply called the standard library's+
:And then:
And for commutativity: