Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add laws to check Short-Circuiting behaviour #3375

Merged

Conversation

gagandeepkalra
Copy link
Contributor

resolves #3355, previously #3327

@codecov-io
Copy link

codecov-io commented Apr 1, 2020

Codecov Report

Merging #3375 into master will decrease coverage by 1.36%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3375      +/-   ##
==========================================
- Coverage   92.69%   91.32%   -1.37%     
==========================================
  Files         379      381       +2     
  Lines        7980     8039      +59     
  Branches      218      228      +10     
==========================================
- Hits         7397     7342      -55     
- Misses        583      697     +114
Flag Coverage Δ
#scala_version_212 91.3% <100%> (-1.42%) ⬇️
#scala_version_213 91.11% <100%> (-1.37%) ⬇️
Impacted Files Coverage Δ
...src/main/scala-2.13+/cats/instances/lazyList.scala 100% <100%> (ø) ⬆️
...src/main/scala/cats/laws/ShortCircuitingLaws.scala 100% <100%> (ø)
core/src/main/scala/cats/instances/queue.scala 100% <100%> (ø) ⬆️
core/src/main/scala/cats/instances/vector.scala 100% <100%> (ø) ⬆️
...la/cats/laws/discipline/ShortCircuitingTests.scala 100% <100%> (ø)
core/src/main/scala/cats/Defer.scala 0% <0%> (-100%) ⬇️
kernel/src/main/scala/cats/kernel/Semigroup.scala 29.41% <0%> (-45.59%) ⬇️
core/src/main/scala/cats/Semigroupal.scala 50% <0%> (-45.46%) ⬇️
core/src/main/scala/cats/FunctorFilter.scala 63.63% <0%> (-36.37%) ⬇️
core/src/main/scala/cats/SemigroupK.scala 64.7% <0%> (-35.3%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 424569f...f65a9e7. Read the comment docs.

Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! :)

@travisbrown
Copy link
Contributor

This looks good to me!

@travisbrown travisbrown merged commit c067cac into typelevel:master May 24, 2020
@gagandeepkalra gagandeepkalra deleted the test/traverse/short-circuiting branch May 24, 2020 09:49
@travisbrown travisbrown added this to the 2.2.0-M2 milestone May 24, 2020
@travisbrown travisbrown added testing and removed build labels May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify short-circuiting behavior and add tests or laws
4 participants