Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add document about Arrow Choice #3390

Merged
merged 3 commits into from
Jun 20, 2020
Merged

Add document about Arrow Choice #3390

merged 3 commits into from
Jun 20, 2020

Conversation

jcouyang
Copy link
Contributor

Choice is actually very useful typeclass, we use that a lot in our Scala and PureScript project, but it seems lack of document in cats elaborate how to actually make use of it.

@codecov-io
Copy link

codecov-io commented Apr 11, 2020

Codecov Report

Merging #3390 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3390   +/-   ##
=======================================
  Coverage   92.70%   92.70%           
=======================================
  Files         379      379           
  Lines        7981     7981           
  Branches      230      227    -3     
=======================================
  Hits         7399     7399           
  Misses        582      582           
Flag Coverage Δ
#scala_version_212 92.73% <ø> (ø)
#scala_version_213 92.49% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1acf25...328895e. Read the comment docs.

julienrf
julienrf previously approved these changes May 13, 2020
Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a nice improvement, thanks @jcouyang!

Can any maintainer have a look?

@jcouyang
Copy link
Contributor Author

thanks @julienrf
didn’t notice it’s still open 🤣

@jcouyang
Copy link
Contributor Author

hmm..anyone keen to have a look the docs?

LukaJCB
LukaJCB previously approved these changes May 25, 2020
Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice, sorry we dropped the ball on reviewing this!

Copy link
Contributor

@barambani barambani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay @jcouyang . Thanks a lot for this great addition. I left few very minor comments.

docs/src/main/tut/typeclasses/arrowchoice.md Outdated Show resolved Hide resolved
docs/src/main/tut/typeclasses/arrowchoice.md Outdated Show resolved Hide resolved
docs/src/main/tut/typeclasses/arrowchoice.md Outdated Show resolved Hide resolved
docs/src/main/tut/typeclasses/arrowchoice.md Outdated Show resolved Hide resolved
docs/src/main/tut/typeclasses/arrowchoice.md Outdated Show resolved Hide resolved
@jcouyang jcouyang dismissed stale reviews from LukaJCB and julienrf via da61d4f June 20, 2020 01:16
@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2020

Codecov Report

Merging #3390 into master will decrease coverage by 0.95%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3390      +/-   ##
==========================================
- Coverage   92.70%   91.74%   -0.96%     
==========================================
  Files         379      383       +4     
  Lines        7981     8399     +418     
  Branches      230      208      -22     
==========================================
+ Hits         7399     7706     +307     
- Misses        582      693     +111     

@jcouyang jcouyang requested a review from barambani June 20, 2020 01:19
Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you!

Copy link
Contributor

@barambani barambani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@barambani barambani merged commit fd586f0 into typelevel:master Jun 20, 2020
@jcouyang jcouyang deleted the docs branch June 21, 2020 00:55
@travisbrown travisbrown added this to the 2.2.0-RC1 milestone Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants