-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add document about Arrow Choice #3390
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3390 +/- ##
=======================================
Coverage 92.70% 92.70%
=======================================
Files 379 379
Lines 7981 7981
Branches 230 227 -3
=======================================
Hits 7399 7399
Misses 582 582
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a nice improvement, thanks @jcouyang!
Can any maintainer have a look?
thanks @julienrf |
hmm..anyone keen to have a look the docs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really nice, sorry we dropped the ball on reviewing this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the delay @jcouyang . Thanks a lot for this great addition. I left few very minor comments.
Codecov Report
@@ Coverage Diff @@
## master #3390 +/- ##
==========================================
- Coverage 92.70% 91.74% -0.96%
==========================================
Files 379 383 +4
Lines 7981 8399 +418
Branches 230 208 -22
==========================================
+ Hits 7399 7706 +307
- Misses 582 693 +111 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Choice
is actually very useful typeclass, we use that a lot in our Scala and PureScript project, but it seems lack of document in cats elaborate how to actually make use of it.