Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ior docs #3478

Merged
merged 4 commits into from
Jun 18, 2020
Merged

Add ior docs #3478

merged 4 commits into from
Jun 18, 2020

Conversation

kazchimo
Copy link
Contributor

add some docs to Ior

@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2020 •
edited
Loading

Codecov Report

Merging #3478 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3478   +/-   ##
=======================================
  Coverage   91.77%   91.77%           
=======================================
  Files         383      383           
  Lines        8394     8394           
  Branches      205      205           
=======================================
  Hits         7704     7704           
  Misses        690      690

@kazchimo @barambani
Update core/src/main/scala/cats/data/Ior.scala
071e4a4 
Co-authored-by: Filippo Mariotti <barambani@users.noreply.github.com>
@kazchimo
Copy link
Contributor Author

@barambani thanks

@barambani
Copy link
Contributor

thank you for the quick fix 👍 .

barambani
barambani approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@barambani barambani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on green

@barambani
Copy link
Contributor

it seems that the Travis notification didn't work. Closing and reopening the PR to try again.

@barambani barambani closed this Jun 18, 2020
@barambani barambani reopened this Jun 18, 2020
@kazchimo kazchimo closed this Jun 18, 2020
@kazchimo kazchimo reopened this Jun 18, 2020
@barambani
Copy link
Contributor

It's running now, thanks.

@kazchimo
Copy link
Contributor Author

kazchimo commented Jun 18, 2020 •
edited
Loading

hmm, law tests seems to fail, but I changed only docs.
How can this be described?

@LukaJCB
Copy link
Member

LukaJCB commented Jun 18, 2020

Unfortunately, it's a flaky test we're aware of. Can you restart the job?

@kazchimo
Copy link
Contributor Author

@LukaJCB thanks for your info.
Is this problem already reported on any issue?
If not, this issue should be made.

@kazchimo kazchimo closed this Jun 18, 2020
@kazchimo kazchimo reopened this Jun 18, 2020
@LukaJCB
Copy link
Member

LukaJCB commented Jun 18, 2020

Yeah it's this: #3353

@LukaJCB
Copy link
Member

LukaJCB commented Jun 18, 2020

Thanks a bunch!

@LukaJCB LukaJCB merged commit bd82436 into typelevel:master Jun 18, 2020
@travisbrown travisbrown added this to the 2.2.0-RC1 milestone Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barambani barambani barambani approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
2.2.0-RC1
Development

Successfully merging this pull request may close these issues.
5 participants
@kazchimo @codecov-commenter @barambani @LukaJCB @travisbrown