Override some Option Apply/Applicative methods #3516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnynek
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3516 +/- ##
==========================================
- Coverage 91.54% 91.49% -0.05%
==========================================
Files 386 386
Lines 8476 8493 +17
Branches 217 230 +13
==========================================
+ Hits 7759 7771 +12
- Misses 717 722 +5 |
barambani
approved these changes
Jul 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Option Applicative is very simple, but the default implementations have a lot of closures and falls back to flatMap/map quite a bit.
By implementing these in terms of ifDefined/get then most of it should be simple JVM bytecode that the jit is very good at optimizing.