Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order for IorT #3555

Merged
merged 1 commit into from
Aug 10, 2020
Merged

Order for IorT #3555

merged 1 commit into from
Aug 10, 2020

Conversation

TimWSpence
Copy link
Member

No description provided.

@TimWSpence
Copy link
Member Author

Dependent on #3554

@TimWSpence TimWSpence mentioned this pull request Aug 7, 2020
@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2020

Codecov Report

Merging #3555 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3555   +/-   ##
=======================================
  Coverage   91.28%   91.29%           
=======================================
  Files         386      386           
  Lines        8574     8577    +3     
  Branches      236      240    +4     
=======================================
+ Hits         7827     7830    +3     
  Misses        747      747           

@TimWSpence TimWSpence mentioned this pull request Aug 7, 2020
@TimWSpence TimWSpence force-pushed the order-for-iort branch 2 times, most recently from 5e972c4 to ddf3bda Compare August 7, 2020 19:31
@TimWSpence
Copy link
Member Author

#3554 is now merged so this is ready for review :)

@travisbrown
Copy link
Contributor

Do you mind rebasing or merging master to update the diff? I never know exactly which one people prefer, but since there hasn't been review here yet I'd probably just rebase.

Copy link
Contributor

@travisbrown travisbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@travisbrown travisbrown merged commit a26f161 into typelevel:master Aug 10, 2020
@travisbrown travisbrown added this to the 2.2.0-RC3 milestone Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants