Add composition to Representable #3831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Realized I forgot to do |
Aux all the things
TimWSpence
force-pushed
the
representable-instances
branch
from
af79276 to
fc7c30b
Compare
johnynek
reviewed
Mar 23, 2021
| { | ||
| type Pair[A] = (A, A) | ||
|
|
||
| //Scala 2.12 implicit resolution absolutely loses its mind here |
There was a problem hiding this comment.
do we need implicit if you are passing them explicitly below?
There was a problem hiding this comment.
Nope, good point. If we remove the modifier then we could probably summon some of them via implicitly as well. Thanks, I'll fix this in both PRs 👍
johnynek
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.