Invariant[Fractional] #4032
Merged
Invariant[Fractional] #4032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmccarthy
commented
Nov 1, 2021
| @@ -70,3 +70,5 @@ trait AllInstancesBinCompat6 extends SortedSetInstancesBinCompat1 with SortedMap | |||
| trait AllInstancesBinCompat7 extends SeqInstances | |||
|
|
|||
| trait AllInstancesBinCompat8 extends DeadlineInstances | |||
|
|
|||
| trait AllInstancesBinCompat9 extends InvariantInstances with InvariantInstancesBinCompat0 | |||
There was a problem hiding this comment.
Note that in 2.12 we were missing InvariantInstances as part of cats.instances.all prior to this PR.
| implicit protected def eqFractional[A: Eq: Arbitrary]: Eq[Fractional[A]] = { | ||
| // This deprecated instance is required since there is not `ExhaustiveCheck` for any types for which a `Fractional` | ||
| // can easily be defined | ||
| import DeprecatedEqInstances.catsLawsEqForFn1 |
There was a problem hiding this comment.
Note that we need to use this instance since there is no type for which both ExhaustiveCheck and Fractional are defined. I attempted to fix this in #3813 with a new MiniFloat type but that made the PR to big.
johnynek
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3794.
This PR adds
Invariant[Fractional], and follows on from #3773, whereInvariant[Numeric]andInvariant[Integral]were added.