Update scalafmt-core to 3.3.0 #4101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, the 3.3.1 update in typelevel/spire#1135 seems a bit strange. |
|
@armanbilge when applied to Cats sources v3.3.1 is even more strange – it changes formatting of boilerplate code and I doubt that we like it. But v3.3.0 looks ok to me. |
rossabaker
approved these changes
Jan 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #4097 has been closed, Scala Steward is not going to resume updating
scalafmt-coreuntil we restart it manually.Therefore this PR restarts these updates.
Note: there's
scalafmt-corev3.3.1 available already and I tried to jump to that version directly, but seems that the most recent version introduces even more weird formatting changes which need to be discussed separately.