Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation/update adopters & contibuting #4124

Merged

Conversation

benkio
Copy link
Contributor

@benkio benkio commented Feb 2, 2022

Updated Adopters sections to this day based on #1099
All Adopters entries case insensitive alphabetically ordered
Update the CONTRIBUTING.md / Generating the Site, mentioning the specific scala-version to use, plus the reference links to the CI workflow

@rossabaker
Copy link
Member

I like the alphabetization. Some companies are grouchy about how their names are stylized, so I'm less sure about the capitalization. (A case-insensitive sort would still do the right thing.)

rossabaker
rossabaker previously approved these changes Feb 2, 2022
README.md Outdated
- [Stripe](https://stripe.com)
- [Stripe](https://stripe.com/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is stripe listed twice? looks like.

README.md Outdated
- [Tecsisa](https://www.tecsisa.com)
- [Teikametrics](http://teikametrics.com)
- [Tenable](https://www.tenable.com)
- [The Guardian](https://www.theguardian.com)
- [The Walt Disney Company](https://www.disney.com)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is also listed above as Disney

@rossabaker rossabaker dismissed johnynek’s stale review February 8, 2022 22:51

I think the objection is addressed. If not, we can do another round.

@rossabaker rossabaker merged commit a4f63eb into typelevel:main Feb 8, 2022
@benkio benkio deleted the documentation/Update_Adopters_&_Contibuting branch February 9, 2022 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants