Update scalafmt-core to 3.4.2

[scala-steward]

Updates org.scalameta:scalafmt-core from 3.4.0 to 3.4.2.
GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:n:2

[satorg]

@armanbilge this time it is only about indentations added to code blocks inside some interpolated strings.

Frankly, I cannot figure out the reasoning for these changes – the formatting looks a bit ugly either with or without them.
But to me it seems being just due to the "nature" of the code involved.

But I am okay with this PR in general unless it breaks anything (seems it does not).
Although some other PRs (like #3871) may encounter additional obstacles because of this one.

Thoughts?
cc @kitbellew in case if you have any comments/thoughts about it.

[johnynek]

I am not a fan of how much churn there is version to version, but I guess we would rather just follow along to the latest version.

That said, I hope people who want scalafmt to churn less and have fewer options voice their support for that view.

[rossabaker]

I like keeping up in the spirit of "standard Scala" (I envy the Gophers in this regard), but I agree with Oscar. The churn adds anoise to the history without clear benefit.

[armanbilge]

If the changes are due to bug fixes (and thus we were relying on buggy behavior) the churn seems unfortunate but unavoidable.

If these changes were unintentional (at least in a patch release, which shouldn't change formatting): @kitbellew can we volunteer the Cats sources as some sort of regression test for scalafmt?

[kitbellew]

If the changes are due to bug fixes (and thus we were relying on buggy behavior) the churn seems unfortunate but unavoidable.

If these changes were unintentional (at least in a patch release, which shouldn't change formatting): @kitbellew can we volunteer the Cats sources as some sort of regression test for scalafmt?

thank you, @armanbilge :)

as to the latest changes, they are indeed bug fixes, the indentation in interpolations was incorrect, until someone noticed.

you could use the new setting newlines.inInterpolation = avoid...

[satorg]

4 approvals for a single PR (including one from me)! Seems that a lot of people are really happy with it. So I guess it would be impolite to keep this PR from being merged :)