Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cats.kernel.Hash port for Scala CHAMP HashMap #4193

Closed
wants to merge 29 commits into from
Closed

cats.kernel.Hash port for Scala CHAMP HashMap #4193

wants to merge 29 commits into from

Commits on May 3, 2022

  1. Initial port of Scala CHAMP HashMap

    @DavidGregory084
    DavidGregory084 committed May 3, 2022
    Configuration menu
    Copy the full SHA
    a1e22f1 View commit details
    Browse the repository at this point in the history

  2. Update access modifiers for HashMap internals

    @DavidGregory084
    DavidGregory084 committed May 3, 2022
    Configuration menu
    Copy the full SHA
    1881a9b View commit details
    Browse the repository at this point in the history

  3. Fix regression in Foldable#iterateRight by ensuring Iterator is alway… 

    …s evaluated
    @DavidGregory084
    DavidGregory084 committed May 3, 2022
    Configuration menu
    Copy the full SHA
    5f93902 View commit details
    Browse the repository at this point in the history

  4. Appease the formatter

    @DavidGregory084
    DavidGregory084 committed May 3, 2022
    Configuration menu
    Copy the full SHA
    2f44919 View commit details
    Browse the repository at this point in the history

  5. Remove sizeHint - it serves no purpose now that size is cached in bit… 

    …map nodes
    @DavidGregory084
    DavidGregory084 committed May 3, 2022
    Configuration menu
    Copy the full SHA
    ff0e86c View commit details
    Browse the repository at this point in the history

  6. Revert sizeHint removal as I was wrong - it prevents erroneous subnod… 

    …e escalation
    @DavidGregory084
    DavidGregory084 committed May 3, 2022
    Configuration menu
    Copy the full SHA
    c655fdd View commit details
    Browse the repository at this point in the history

  7. Narrow conditions for subnode escalation

    @DavidGregory084
    DavidGregory084 committed May 3, 2022
    Configuration menu
    Copy the full SHA
    ef63d19 View commit details
    Browse the repository at this point in the history

  8. Use byteswap hashing in HashMap to improve input hash

    @DavidGregory084
    DavidGregory084 committed May 3, 2022
    Configuration menu
    Copy the full SHA
    7dabe64 View commit details
    Browse the repository at this point in the history

  9. Add copyright notice from Scala standard library to meet license obli… 

    …gations as a derived work
    @DavidGregory084
    DavidGregory084 committed May 3, 2022
    Configuration menu
    Copy the full SHA
    5864984 View commit details
    Browse the repository at this point in the history

  10. Add benchmarks for HashMap

    @DavidGregory084
    DavidGregory084 committed May 3, 2022
    Configuration menu
    Copy the full SHA
    3fdf9d5 View commit details
    Browse the repository at this point in the history

  11. Override concrete UnorderedFoldable operations for HashMap

    @DavidGregory084
    DavidGregory084 committed May 3, 2022
    Configuration menu
    Copy the full SHA
    d5e7596 View commit details
    Browse the repository at this point in the history

  12. Override even more concrete UnorderedFoldable operations for HashMap

    @DavidGregory084
    DavidGregory084 committed May 3, 2022
    Configuration menu
    Copy the full SHA
    186264f View commit details
    Browse the repository at this point in the history

Commits on May 16, 2022

  1. Addressing review comments: 

    * Use primitive HashMap operations when generating random HashMaps
* Use a better approach to test HashMap key collisions
* Remove reverseIterator
* Foldable.iterateRight signature changed
* HashMap#add renamed to HashMap#updated
* HashMap#remove renamed to HashMap#removed
* Added HashMap.fromFoldable
* Renamed CHAMP node element count fields
* Use NonEmptyVector in CHAMP collision node
* Fixed various nits
    @DavidGregory084
    DavidGregory084 committed May 16, 2022
    Configuration menu
    Copy the full SHA
    151e52d View commit details
    Browse the repository at this point in the history

  2. Add a test for collectFirst to NonEmptyCollectionSuite

    @DavidGregory084
    DavidGregory084 committed May 16, 2022
    Configuration menu
    Copy the full SHA
    5c15c53 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2022

  1. Fix key-value bitmap calculation when subnodes are propagated as the … 

    …new root node
    @DavidGregory084
    DavidGregory084 committed May 17, 2022
    Configuration menu
    Copy the full SHA
    0169ce3 View commit details
    Browse the repository at this point in the history

  2. Add tests for consistency between String representation and equality

    @DavidGregory084
    DavidGregory084 committed May 17, 2022
    Configuration menu
    Copy the full SHA
    b292134 View commit details
    Browse the repository at this point in the history

  3. Reduce duplication in 2.12 concat, remove an unnecessary branch

    @DavidGregory084
    DavidGregory084 committed May 17, 2022
    Configuration menu
    Copy the full SHA
    27a69d3 View commit details
    Browse the repository at this point in the history

  4. Weaken show / equality laws due to collisions

    @DavidGregory084
    DavidGregory084 committed May 17, 2022
    Configuration menu
    Copy the full SHA
    6203e1a View commit details
    Browse the repository at this point in the history

  5. Add a toMap operation that returns a Map wrapper for HashMap

    @DavidGregory084
    DavidGregory084 committed May 17, 2022
    7 Configuration menu
    Copy the full SHA
    0f66333 View commit details
    Browse the repository at this point in the history

  6. Add copyright headers for WrappedHashMap

    @DavidGregory084
    DavidGregory084 committed May 17, 2022
    Configuration menu
    Copy the full SHA
    a4732f2 View commit details
    Browse the repository at this point in the history

  7. Avoid allocating tuple in HashMapBench

    @DavidGregory084
    DavidGregory084 committed May 17, 2022
    Configuration menu
    Copy the full SHA
    ea5c7de View commit details
    Browse the repository at this point in the history

  8. Address review comments

    @DavidGregory084
    DavidGregory084 committed May 17, 2022
    Configuration menu
    Copy the full SHA
    7cc3ade View commit details
    Browse the repository at this point in the history

Commits on May 23, 2022

  1. Address further review comments: 

    * Reduce allocations by implementing Node#getMapping
* Improve performance of CollisionNode by making better use of Vector operations
* Improve performance of HashMap#concat by iterating over the smaller HashMap
    @DavidGregory084
    DavidGregory084 committed May 23, 2022
    Configuration menu
    Copy the full SHA
    d25015f View commit details
    Browse the repository at this point in the history

  2. Change formatting of HashMapMonoid#combine

    @DavidGregory084
    DavidGregory084 committed May 23, 2022
    Configuration menu
    Copy the full SHA
    d572156 View commit details
    Browse the repository at this point in the history

  3. Fix inconsistency in benchmark names

    @DavidGregory084
    DavidGregory084 committed May 23, 2022
    Configuration menu
    Copy the full SHA
    ea31a5d View commit details
    Browse the repository at this point in the history

Commits on May 24, 2022

  1. Implement a concat operation on BitMapNode to merge the CHAMP structures

    @DavidGregory084
    DavidGregory084 committed May 24, 2022
    Configuration menu
    Copy the full SHA
    e7343e8 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2022

  1. Revert "Implement a concat operation on BitMapNode to merge the CHAMP… 

    … structures"

This reverts commit e7343e8.
    @DavidGregory084
    DavidGregory084 committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    a64bcf7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:typelevel/cats into eq-based-map

    @DavidGregory084
    DavidGregory084 committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    0a2ff88 View commit details
    Browse the repository at this point in the history

  3. Update formatting for new scalafmt version

    @DavidGregory084
    DavidGregory084 committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    9cc8be6 View commit details
    Browse the repository at this point in the history