Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove simulacrum #4210

Merged
merged 1 commit into from
May 23, 2022
Merged

Remove simulacrum #4210

merged 1 commit into from
May 23, 2022

Conversation

BalmungSan
Copy link
Contributor

This is a dumb search and replace and is mostly intended as a conversation starter and maybe as a base for someone else to pick up and finish more advanced changes.

@armanbilge
Copy link
Member

armanbilge commented May 21, 2022

For context, see the following PRs where instructions to run scalafix simulacrum in the Cats' sources were more trouble than help.

See also plans to enable "organize imports" and other helpful CI-verified scalafixes via sbt-typelevel, which would have friction with the simualcrum scalafixes in this repository.

johnynek
johnynek previously approved these changes May 23, 2022
Copy link
Contributor

@johnynek johnynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that this can be removed without a Mima issue.

@armanbilge
Copy link
Member

armanbilge commented May 23, 2022

We can also remove this file.

cats/.scalafix.conf

Lines 1 to 10 in 15f75f7

rules = [
AddSerializable
AddImplicitNotFound
TypeClassSupport
]
TypeClassSupport.opsObjectDeprecation = {
message = "Use cats.syntax object imports"
since = "2.2.0"
}

@BalmungSan
Copy link
Contributor Author

I just removed more references to simulacrum.

Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spear-heading this change.

@johnynek johnynek merged commit f2c78d9 into typelevel:main May 23, 2022
@BalmungSan BalmungSan deleted the remove-simulacrum branch May 23, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants