-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove simulacrum #4210
Remove simulacrum #4210
Conversation
For context, see the following PRs where instructions to run scalafix simulacrum in the Cats' sources were more trouble than help. See also plans to enable "organize imports" and other helpful CI-verified scalafixes via sbt-typelevel, which would have friction with the simualcrum scalafixes in this repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice that this can be removed without a Mima issue.
We can also remove this file. Lines 1 to 10 in 15f75f7
|
15f75f7
to
75451cc
Compare
I just removed more references to simulacrum. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for spear-heading this change.
This is a dumb search and replace and is mostly intended as a conversation starter and maybe as a base for someone else to pick up and finish more advanced changes.