-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose newtype objects to Mima #4219
Conversation
bf2194c
to
c6cc133
Compare
c6cc133
to
5cd610b
Compare
Hmm... Looks like making the
Whereas the previouls solution (with If I said that now I understand just nothing – it wouldn't be too far from the truth... |
Right, that's because as I said, we already broke binary compatibility. Now that you've made it public, MiMa is actually able to check bincompat :) this is why I think the is the right strategy forward. See #4219 (comment) for a patch to fix it. |
Ah ok, now I got it (finally). Thanks. |
5cd610b
to
de5357b
Compare
@armanbilge I've updated the PR, take one more look please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 excellent scaladoc comment, thank you! Just a small typo :)
de5357b
to
5c2a0c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for identifying and investigating this issue so thoroughly!
5c2a0c0
to
96966e4
Compare
96966e4
to
d6fb9df
Compare
I think I can merge it now – it shouldn't make things worse somehow. |
The motivation for this PR is discussed here: #4187 (comment)