Add EitherT#biSemiflatTap which combines leftSemiflatTap and semiflatTap
#4293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satorg
reviewed
Sep 9, 2022
exp0nge
force-pushed
the
md-eithert-biSemiflatTap
branch
from
04f5adb
to
393b5b8
Compare
satorg
reviewed
Sep 9, 2022
satorg
previously approved these changes
Sep 9, 2022
exp0nge
force-pushed
the
md-eithert-biSemiflatTap
branch
from
393b5b8
to
9d2fa4d
Compare
loosen to FlatMap formatting
exp0nge
force-pushed
the
md-eithert-biSemiflatTap
branch
from
9d2fa4d
to
bde7b16
Compare
armanbilge
changed the title
EitherT#biSemiflatTap which combines leftSemiflatTap and semiflatTap
armanbilge
approved these changes
Sep 10, 2022
There was a problem hiding this comment.
LGTM, thank you very much!
Related: we have another PR with enhancements for EitherT in #2237. I haven't had a chance to work on it lately, but if someone is interested it just needs some polishing and tests :)
|
Ok great! Let me merge it then. Thank you @exp0nge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly a ergonomics style PR 😄
I did notice some chatter around not wrapping/unwrapping so much because this method could be reduced to chaining
semiflatTap+leftSemiflatTap. Doesn't make too much of a difference to me either way if you guys want me to change it to chaining.Fixes #4292