Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update scalaz-core to 7.3.7 #4354

Closed
wants to merge 1 commit into from
Closed

Update scalaz-core to 7.3.7 #4354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ lazy val bench = project
.settings(commonJvmSettings)
.settings(
libraryDependencies ++= Seq(
"org.scalaz" %% "scalaz-core" % "7.3.6"
"org.scalaz" %% "scalaz-core" % "7.3.7"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does one else feel that we can give up on this dep? Only one suite with few benchmarks depends on it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmarks are all about comparing to useful reference points that are well understood. At the time, I think scalaz was just such a reference point, but I would have a hard time arguing that it remains so today. I would be in favor of removing these measurements.

),
evictionErrorLevel := Level.Warn
)
Expand Down