Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish alleycats docs on website #4393

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Publish alleycats docs on website #4393

merged 1 commit into from
Feb 6, 2023

Conversation

armanbilge
Copy link
Member

No description provided.

@satorg
Copy link
Contributor

satorg commented Feb 6, 2023

I wonder if it makes sense to change import cats.implicits._ to import cats.syntax.all._ along with the other changes here. Just to keep encouraging everyone using the new way of importing all the syntax:

cats/docs/alleycats.md

Lines 106 to 107 in e666c09

import cats.implicits._
import alleycats.std.iterable._

satorg
satorg approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@satorg satorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@armanbilge
Copy link
Member Author

What we need is someone to just do a big ol' find/replace :)

@armanbilge armanbilge merged commit ccd576f into typelevel:main Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satorg satorg satorg approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armanbilge @satorg