-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete PR template #4459
Delete PR template #4459
Conversation
Stop asking contributors to run `+prePR`. That's a way too heavy operation for a laptop due to Scala native. It's better to open a PR and let CI check it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tend to agree with this removal. But according to the cats
usage of Scala Native, a regular contributor could unlikely break it. Maybe we can create some handy alias for JVM only?
Perhaps. I couldn't find where it's defined so I'm not even sure what it does 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also agree, regardless of Scala Native +prePR
is always hitting a nail with a hammer. Chances are you actually only need to format 1 or 2 files you happened to touch (I use right-click in VSCode metals to do this per-file, there's also a shortcut).
I think it would still be useful to have some guide for users here. Fortunately all projects are working the same so maybe we can add something to sbt-typelevel docs and link to it from all the Typelevel PR templates. e.g. if formatting fails in CI, run scalafmt
, if Scala version x.y.z fails to compile run ++ x.y.z compile
, etc.
That doesn't look like something which can run only on the JVM subprojects |
Thank you! |
Stop asking contributors to run
+prePR
.That's a way too heavy operation for a laptop due to Scala native. It's better to open a PR and let CI check it.
No, thanks! I have to
kill -9
it if I try 😄