Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete PR template #4459

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Delete PR template #4459

merged 1 commit into from
Jun 13, 2023

Conversation

joroKr21
Copy link
Member

Stop asking contributors to run +prePR.
That's a way too heavy operation for a laptop due to Scala native. It's better to open a PR and let CI check it.

Thank you for contributing to Cats!

This is a kind reminder to run sbt +prePR and commit the changed files, if any, before submitting.

No, thanks! I have to kill -9 it if I try 😄

Stop asking contributors to run `+prePR`.
That's a way too heavy operation for a laptop due to Scala native.
It's better to open a PR and let CI check it.
Copy link
Member

@danicheg danicheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tend to agree with this removal. But according to the cats usage of Scala Native, a regular contributor could unlikely break it. Maybe we can create some handy alias for JVM only?

@joroKr21
Copy link
Member Author

Perhaps. I couldn't find where it's defined so I'm not even sure what it does 🤔

Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also agree, regardless of Scala Native +prePR is always hitting a nail with a hammer. Chances are you actually only need to format 1 or 2 files you happened to touch (I use right-click in VSCode metals to do this per-file, there's also a shortcut).

I think it would still be useful to have some guide for users here. Fortunately all projects are working the same so maybe we can add something to sbt-typelevel docs and link to it from all the Typelevel PR templates. e.g. if formatting fails in CI, run scalafmt, if Scala version x.y.z fails to compile run ++ x.y.z compile, etc.

@joroKr21
Copy link
Member Author

That doesn't look like something which can run only on the JVM subprojects

@satorg
Copy link
Contributor

satorg commented Jun 13, 2023

Thank you!

@satorg satorg merged commit 9ad3aa5 into typelevel:main Jun 13, 2023
@joroKr21 joroKr21 deleted the pre-pr branch June 13, 2023 07:16
@armanbilge armanbilge added the behind-the-scenes appreciated, but not user-facing label Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behind-the-scenes appreciated, but not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants