Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nscplugin, sbt-scala-native to 0.5.1 #4585

Merged
merged 9 commits into from
May 25, 2024
Merged

Conversation

typelevel-steward[bot]
Copy link
Contributor

About this PR

πŸ“¦ Updates

from 0.4.17 to 0.5.1

πŸ“œ GitHub Release Notes - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-native" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-native" }
}]
labels: library-update, early-semver-major, semver-spec-minor, commit-count:1

@mpilquist mpilquist linked an issue Apr 17, 2024 that may be closed by this pull request
@satorg
Copy link
Contributor

satorg commented Apr 18, 2024

Seems blocked by typelevel/discipline#446,

@satorg
Copy link
Contributor

satorg commented May 1, 2024

+ Update scalacheck to 1.18.0
+ Update discipline-core to 1.7.0
+ Update discipline-munit to 2.0.0-M4

@satorg
Copy link
Contributor

satorg commented May 2, 2024

Ok, the checks are passing now πŸŽ‰
@armanbilge @mpilquist could you verify that tlVersionIntroduced and other settings are properly re-aligned here in the PR please? Thank you!

@armanbilge
Copy link
Member

Can we take a pass through the project and remove all the weird stuff we did b/c Scala Native didn't support multi-threading? For example this should no longer be necessary:

// TODO: We shouldn't do this! See: https://github.com/scala-js/scala-js/issues/2102
implicit private object SynchronousExecutor extends ExecutionContextExecutor {

Probably we can now share that suite between JVM and Native.

Thanks!

A special synchronous executor for scala-native is no longer needed
for FutureSuite as scala-native 0.5.x is multi-threaded. FutureSuite
is now shared between JVM and Native.
@kapunga
Copy link
Contributor

kapunga commented May 12, 2024

Can we take a pass through the project and remove all the weird stuff we did b/c Scala Native didn't support multi-threading? For example this should no longer be necessary:

// TODO: We shouldn't do this! See: https://github.com/scala-js/scala-js/issues/2102
implicit private object SynchronousExecutor extends ExecutionContextExecutor {

Probably we can now share that suite between JVM and Native.

Thanks!

Wasn't sure if anyone was working on this so I went ahead and opened a PR: #4601

mpilquist
mpilquist previously approved these changes May 13, 2024
Remove special ExecutionContextExecutor
Copy link
Member

@danicheg danicheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is constantly failing with

[error] Test runner interrupted by fatal signal 11
[warn] Force close java.lang.RuntimeException: Process /home/runner/work/cats/cats/tests/native/target/scala-2.13/cats-tests-test finished with non-zero value 139 (0x8b)


val disciplineMunitVersion = "2.0.0-M3"
val disciplineMunitVersion = "2.0.0-M4"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right. However, I think it wouldn't hurt if we address it in a separate PR to avoid stuffing up this one.

It would be perfect, if @typelevel-steward could wake up and create such a PR for us.

@satorg satorg merged commit 6529b30 into main May 25, 2024
17 checks passed
@satorg satorg deleted the update/nscplugin-0.5.1 branch May 25, 2024 01:18
@danicheg
Copy link
Member

Shall we publish a fresh release?

@mpilquist
Copy link
Member

@armanbilge and I were discussing a release plan yesterday on Discord. He suggested a Cats 2.11.0 release against Native 0.4 and then an immediate Cats 2.12.0 release against Native 0.5. To do so, we'll have to temporarily downgrade native on main branch.

@armanbilge
Copy link
Member

To do so, we'll have to temporarily downgrade native on main branch.

Not necessarily. We can tag 3c7474b (the commit prior to merging this PR) as v2.11.0. The v2.11.0 release will be missing any PRs that were merged after, such as #4602.

@satorg
Copy link
Contributor

satorg commented May 25, 2024

The v2.11.0 release will be missing any PRs that were merged after

Actually, there were exactly two of them:

@armanbilge
Copy link
Member

armanbilge commented May 25, 2024

Right, but #4605 would be unable to land in v2.11.0 anyway :)

@sideeffffect
Copy link
Contributor

Hello good people here, may I ask what did you do to fix/workaround the problem with

finished with non-zero value 139

#4585 (review)
?

valencik added a commit to valencik/cats-parse that referenced this pull request Jul 31, 2024
johnynek pushed a commit to typelevel/cats-parse that referenced this pull request Jul 31, 2024
* Update scala-library to 2.13.14

* Update cats to 2.12.0

* Update scala-native to 0.5.4

* Update munit deps to 1.0.0

* Fix munit deps for Scala 2.11

* Fix build.sbt formatting

* Fix repeated naming warning / error

* Reset tlVersionIntroduced for Scala Native 0.5

Trying to follow the approach taken in
typelevel/cats#4585
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Scala Native 0.5
7 participants