Expose FunctionK.liftFunction as a part of the Scala 3 API #4600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomadchin
force-pushed
the
feature/scala3-functionK-lift-port
branch
2 times, most recently
from
cf011ea
to
237a489
Compare
pomadchin
force-pushed
the
feature/scala3-functionK-lift-port
branch
from
237a489
to
baec5e0
Compare
joroKr21
approved these changes
May 12, 2024
satorg
reviewed
May 13, 2024
Comment on lines
+38
to
+44
| test("lift a function directly using Scala 2 compatible syntax") { | ||
| def headOption[A](list: List[A]): Option[A] = list.headOption | ||
| val fHeadOption = FunctionK.liftFunction[List, Option](headOption) | ||
| forAll { (a: List[Int]) => | ||
| assert(fHeadOption(a) === a.headOption) | ||
| } | ||
| } |
There was a problem hiding this comment.
Just to note: I feel this test case should be extracted into a new test suite that would cross-compile for both Scala2 and Scala3. Looks like there's no such test suite available for FunctionK. We can do it in a separate follow up PR though.
There was a problem hiding this comment.
Ooh that's a good idea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds liftFunction into the Scala 3 API.
That would help us to remove FunctionKLift from cats-tagless and from a couple of other libraries. Right now I'm just borrowing this file around :D
Closes #4449
cc @joroKr21