Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aliases traverseVoid/sequenceVoid and their counterparts #4682

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

satorg
Copy link
Contributor

@satorg satorg commented Nov 28, 2024

Closes #4611.

The feedback on the original proposal seems generally favorable, therefore here is the PR. Overall, it does the following:

  • adds traverseVoid/sequenceVoid to Foldable (convering traverse_ and sequence_ to aliases for the new methods);
  • similarly, adds nonEmptyTraverseVoid/nonEmptySequenceVoid;
  • similarly, adds corresponding new methods to Parallel/NonEmptyParallel;
  • redirects customized implementations in data instances to the new methods;
  • makes laws and tests using the new methods instead of the old ones.

Also it adds some comments to the places that haven't been changed but could be and thereby explaining why.

@satorg satorg self-assigned this Nov 28, 2024
@satorg satorg changed the title Aliases traverseVoid/sequenceVoid and their counterparts Aliases traverseVoid/sequenceVoid and their counterparts Nov 28, 2024
@satorg
Copy link
Contributor Author

satorg commented Nov 28, 2024

@ken1ma, fyi, because you referenced the original inssue in #4661 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PROPOSAL] Aliases for methods traverse_ and sequence_
1 participant