Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add StreamingT tests and fix some uncovered bugs #656

Merged
merged 3 commits into from
Nov 16, 2015
Merged

Add StreamingT tests and fix some uncovered bugs #656

merged 3 commits into from
Nov 16, 2015

Conversation

ceedubs
Copy link
Contributor

@ceedubs ceedubs commented Nov 15, 2015

And add a couple unit tests for take/drop on StreamingT

@ceedubs
Fix bug in StreamingT.drop
4ae6f6a 
And add a couple unit tests for take/drop on StreamingT
@ceedubs
Relocate StreamingT.take/drop tests
6228c62 
Putting them into the StreamintTTests class to be consistent with other
tests.
@stew
Copy link
Contributor

stew commented Nov 16, 2015

👍

@codecov-io
Copy link

Current coverage is 80.91%

Merging #656 into master will increase coverage by +1.99% as of 2fe5b4a

@@            master    #656   diff @@
======================================
  Files          159     159       
  Stmts         2121    2122     +1
  Branches        72      72       
  Methods          0       0       
======================================
+ Hit           1674    1717    +43
  Partial          0       0       
+ Missed         447     405    -42

Review entire Coverage Diff as of 2fe5b4a

Powered by Codecov. Updated on successful CI builds.

@ceedubs
Copy link
Contributor Author

ceedubs commented Nov 16, 2015

I've added some more tests and uncovered some more bugs. I'm going to go ahead and add them to this PR.

@ceedubs
Add more StreamingT tests and fix uncovered bugs
6bd6152 
* isEmpty and nonEmpty were mixed up
* dropWhile was doing takeWhile in the case of Cons
@ceedubs
Copy link
Contributor Author

ceedubs commented Nov 16, 2015

Newly fixed bugs:

  • isEmpty and nonEmpty were mixed up
  • dropWhile was doing takeWhile in the case of Cons

@ceedubs ceedubs changed the title Fix bug in StreamingT.drop Add StreamingT tests and fix some uncovered bugs Nov 16, 2015
@ceedubs
Copy link
Contributor Author

ceedubs commented Nov 16, 2015

This PR will bump Cats over the 80% test coverage mark! ✨

@adelbertc
Copy link
Contributor

Woot! 👍

@stew
Copy link
Contributor

stew commented Nov 16, 2015

nice :) 👍

stew added a commit that referenced this pull request Nov 16, 2015
@stew
Merge pull request #656 from ceedubs/fix-streamingt-drop
f4db3c4 
Add StreamingT tests and fix some uncovered bugs
@stew stew merged commit f4db3c4 into typelevel:master Nov 16, 2015
@stew stew removed the in progress label Nov 16, 2015
@ceedubs ceedubs deleted the fix-streamingt-drop branch November 16, 2015 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ceedubs @stew @codecov-io @adelbertc