Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Arbitrary Streaming instances more arbitrary #660

Merged
merged 1 commit into from
Nov 19, 2015

Conversation

ceedubs
Copy link
Contributor

@ceedubs ceedubs commented Nov 16, 2015

This commit does two things.

  1. Use a frequency distribution in the StreamingT generator as
    suggested by @non here.
    It is now twice as likely to generate a Wait as an Empty and 6 times as
    likely to generate a Cons as an Empty.
  2. Update the Streaming generator to be similar to the StreamingT
    generator (use a frequency distribution generator of Empty, Wait, and
    Cons).

This commit does two things.

1) Use a frequency distribution in the `StreamingT` generator as
suggested by @non [here](https://github.com/non/cats/pull/649#issuecomment-156856211).
It is now twice as likely to generate a Wait as an Empty and 6 times as
likely to generate a Cons as an Empty.
2) Update the `Streaming` generator to be similar to the `StreamingT`
generator (use a frequency distribution generator of Empty, Wait, and
Cons).
@non
Copy link
Contributor

non commented Nov 16, 2015

👍

@codecov-io
Copy link

Current coverage is 81.11%

Merging #660 into master will increase coverage by +0.20% as of b1e1968

@@            master    #660   diff @@
======================================
  Files          159     159       
  Stmts         2122    2134    +12
  Branches        72      74     +2
  Methods          0       0       
======================================
+ Hit           1717    1731    +14
  Partial          0       0       
+ Missed         405     403     -2

Review entire Coverage Diff as of b1e1968

Powered by Codecov. Updated on successful CI builds.

@adelbertc
Copy link
Contributor

👍

adelbertc added a commit that referenced this pull request Nov 19, 2015
Make Arbitrary Streaming instances more arbitrary
@adelbertc adelbertc merged commit d18a9bf into typelevel:master Nov 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants