Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make tut doc ever so slightly less hideous #709

Merged
merged 1 commit into from
Dec 3, 2015

Conversation

tpolecat
Copy link
Member

@tpolecat tpolecat commented Dec 2, 2015

This PR adds the :silent modifier to code blocks that contain only definitions (and in a few cases splits mixed blocks). The resulting tut doc is much cleaner.

}
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This compile error wasn't detected because the file ended with a code block without a closing } so the REPL was left hanging. Nice work isolating a corner case!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, this is because of tpolecat/tut#65.

@codecov-io
Copy link

Current coverage is 85.01%

Merging #709 into master will not affect coverage as of 910e7e5

@@            master    #709   diff @@
======================================
  Files          162     162       
  Stmts         2229    2229       
  Branches        74      74       
  Methods          0       0       
======================================
  Hit           1895    1895       
  Partial          0       0       
  Missed         334     334       

Review entire Coverage Diff as of 910e7e5

Powered by Codecov. Updated on successful CI builds.

@ceedubs
Copy link
Contributor

ceedubs commented Dec 2, 2015

Wow, thanks for going through and doing this, @tpolecat! 👍

@adelbertc
Copy link
Contributor

👍

adelbertc added a commit that referenced this pull request Dec 3, 2015
make tut doc ever so slightly less hideous
@adelbertc adelbertc merged commit 60ad91a into typelevel:master Dec 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants