Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make StreamingT toString more like Streaming toString #722

Merged
merged 1 commit into from
Dec 7, 2015

Conversation

ceedubs
Copy link
Contributor

@ceedubs ceedubs commented Dec 7, 2015

Before this, StreamingT was always returning "StreamingT(...)" for its
toString. It's now similar to Streaming in that it will return
"StreamingT()" in the case of Empty and will show the head element in
the case of Cons.

I also added a pretty weak test for its toString (which actually doesn't
capture my changes at all). It may be good to add further tests in the
future, but I've got to get to work, and I think this is at least an
improvement to the current status.

Before this, StreamingT was always returning "StreamingT(...)" for its
toString. It's now similar to Streaming in that it will return
"StreamingT()" in the case of Empty and will show the head element in
the case of Cons.

I also added a pretty weak test for its toString (which actually doesn't
capture my changes at all). It may be good to add further tests in the
future, but I've got to get to work, and I think this is at least an
improvement to the current status.
@codecov-io
Copy link

Current coverage is 85.58%

Merging #722 into master will increase coverage by +0.06% as of 986fdc6

@@            master    #722   diff @@
======================================
  Files          162     162       
  Stmts         2245    2247     +2
  Branches        74      74       
  Methods          0       0       
======================================
+ Hit           1920    1923     +3
  Partial          0       0       
+ Missed         325     324     -1

Review entire Coverage Diff as of 986fdc6

Powered by Codecov. Updated on successful CI builds.

@adelbertc
Copy link
Contributor

👍

fthomas added a commit that referenced this pull request Dec 7, 2015
Make StreamingT toString more like Streaming toString
@fthomas fthomas merged commit b8be77b into typelevel:master Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants