Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs duped url slashes #768

Merged
merged 2 commits into from
Jan 5, 2016

Conversation

longcao
Copy link
Contributor

@longcao longcao commented Dec 21, 2015

I'm not super experienced with Jekyll but I took a shot at fixing some of the urls in the documentation by following the advice here in http://stackoverflow.com/a/21441767, there were duped slashes in the URLs that were really annoying me for no good reason. I took a cursory once-over if anything was 404'ing and couldn't find anything.

note: went ahead and deleted the .config.dev.yml since that wasn't working and testing with the regular .config.yml was good and dandy.

@non
Copy link
Contributor

non commented Jan 4, 2016

👍 once tests pass (re-running now, output seemed flaky)

@longcao longcao force-pushed the fix-docs-duped-url-slashes branch from f9f2d95 to 70dadfb Compare January 4, 2016 18:33
@longcao
Copy link
Contributor Author

longcao commented Jan 4, 2016

Looks like a failing test not related to the docs changes...

[info] *** 1 TEST FAILED ***
[error] Failed: Total 1913, Failed 1, Errors 0, Passed 1912
[error] Failed tests:
[error]     cats.tests.FoldableTestsAdditional
[error] (testsJS/test:test) sbt.TestsFailedException: Tests unsuccessful
[error] Total time: 323 s, completed Jan 4, 2016 5:46:17 AM

I pushed a rebased version of my branch, let's see if that fixes it.

@longcao
Copy link
Contributor Author

longcao commented Jan 4, 2016

hmm, that didn't seem to fix it and I'm not entirely sure why. from a glance the other PRs don't seem to be having this problem, though...

@DavidGregory084
Copy link
Member

@longcao I have had a go at fixing this problem in #769 but it's not merged yet

@codecov-io
Copy link

Current coverage is 88.43%

Merging #768 into master will decrease coverage by -0.05% as of bc4707b

@@            master    #768   diff @@
======================================
  Files          166     166       
  Stmts         2283    2318    +35
  Branches        74      74       
  Methods          0       0       
======================================
+ Hit           2020    2050    +30
  Partial          0       0       
- Missed         263     268     +5

Review entire Coverage Diff as of bc4707b

Powered by Codecov. Updated on successful CI builds.

@ceedubs
Copy link
Contributor

ceedubs commented Jan 5, 2016

Thanks, @longcao! Those duplicate slashes were also bothering me :)

ceedubs added a commit that referenced this pull request Jan 5, 2016
@ceedubs ceedubs merged commit 971f954 into typelevel:master Jan 5, 2016
@longcao longcao deleted the fix-docs-duped-url-slashes branch January 6, 2016 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants