Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Traverse instance for OneAnd #816

Merged
merged 4 commits into from
Jan 26, 2016
Merged

Traverse instance for OneAnd #816

merged 4 commits into from
Jan 26, 2016

Conversation

notxcain
Copy link
Contributor

This PR adds Traverse instance for OneAnd[F, ?] where F: Traverse

adelbertc
adelbertc reviewed Jan 18, 2016
View reviewed changes
tests/src/test/scala/cats/tests/OneAndTests.scala
@@ -13,6 +13,8 @@ import scala.util.Random
class OneAndTests extends CatsSuite {
checkAll("OneAnd[List, Int]", OrderLaws[OneAnd[List, Int]].eqv)

checkAll("OneAnd[List, Int] with Option", TraverseTests[OneAnd[List, ?]].traverse[Int, Int, Int, Int, Option, Option])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add the check the serializability of the Traverse instance as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

mikejcurry
mikejcurry reviewed Jan 19, 2016
View reviewed changes
tests/src/test/scala/cats/tests/OneAndTests.scala
@@ -13,6 +13,9 @@ import scala.util.Random
class OneAndTests extends CatsSuite {
checkAll("OneAnd[List, Int]", OrderLaws[OneAnd[List, Int]].eqv)

checkAll("OneAnd[List, Int] with Option", TraverseTests[OneAnd[List, ?]].traverse[Int, Int, Int, Int, Option, Option])
checkAll("Functor[OneAnd[List, A]]", SerializableTests.serializable(Traverse[OneAnd[List, ?]]))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super minor, but Functor should probably be replaced with Traverse for the name of the Serializable test, to reflect the check being performed.

@notxcain
Copy link
Contributor Author

Was very sleepy yesterday. Fixed!

@codecov-io
Copy link

Current coverage is 89.14%

Merging #816 into master will increase coverage by +0.03% as of 79cb926

@@            master    #816   diff @@
======================================
  Files          168     168       
  Stmts         2306    2312     +6
  Branches        75      75       
  Methods          0       0       
======================================
+ Hit           2055    2061     +6
  Partial          0       0       
  Missed         251     251

Review entire Coverage Diff as of 79cb926

Powered by Codecov. Updated on successful CI builds.

@notxcain
Copy link
Contributor Author

Is there something more I have to do?

@stew
Copy link
Contributor

stew commented Jan 23, 2016

👍

@ceedubs
Copy link
Contributor

ceedubs commented Jan 26, 2016

Great. Thanks, @notxcain!

ceedubs added a commit that referenced this pull request Jan 26, 2016
@ceedubs
Merge pull request #816 from notxcain/master
acbe54e 
Traverse instance for OneAnd
@ceedubs ceedubs merged commit acbe54e into typelevel:master Jan 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@notxcain @codecov-io @stew @ceedubs @adelbertc @mikejcurry