-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update free monad docs #832
Conversation
This resolves typelevel#804. I also updated the "pure" compiler to use `State`. It previously had said that a pure compiler couldn't be written and used with `foldMap`, but that's not really true if you use something like `State`. I think this is probably a cleaner and more useful solution.
Current coverage is
|
4. Build a program out of key-value DSL operations. | ||
5. Build a compiler for programs of DSL operations. | ||
6. Execute our compiled program. | ||
2. Create smart constructors for `KVStore[_]` using `liftF`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An alternative to liftF
is to use Free.inject
when targeting cats.data.Coproduct
as a composition mechanism maybe it should be mentioned here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it's mentioned below. Perhaps we should consider adding some kind of TOC at the beginning of each tutorial to show at a glance the different sections and topics being described.
@ceedubs LGTM!. My comments are just suggestion for future consideration in case the tutorials become too long. |
👍 |
yes that was required! thanks for the effort ;) |
Thanks for the quick feedback everyone. @raulraja I agree that tables of contents might be helpful in docs. I'll create a separate issue to track that. |
This resolves #804.
I also updated the "pure" compiler to use
State
. It previously hadsaid that a pure compiler couldn't be written and used with
foldMap
,but that's not really true if you use something like
State
. I thinkthis is probably a cleaner and more useful solution.
@mandubian @raulraja would you be available to review?