Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse order of arguments for ap #833

Merged
merged 5 commits into from
Jan 30, 2016

Conversation

travisbrown
Copy link
Contributor

This is a follow-up to #821 that rebases @lukewyman's changes, makes some fixes supported by the new version of Simulacrum, and updates the docs.

Note that I've renamed ap on CartesianBuilderN to apWith to avoid confusion (since the function comes after the arguments in that case).

@non
Copy link
Contributor

non commented Jan 30, 2016

Seems reasonable to me. 👍

@ceedubs
Copy link
Contributor

ceedubs commented Jan 30, 2016

Looks good. 👍 as long as the build passes.

@codecov-io
Copy link

Current coverage is 89.26%

Merging #833 into master will decrease coverage by -0.04% as of 989178b

@@            master    #833   diff @@
======================================
  Files          168     168       
  Stmts         2319    2319       
  Branches        75      75       
  Methods          0       0       
======================================
- Hit           2071    2070     -1
  Partial          0       0       
- Missed         248     249     +1

Review entire Coverage Diff as of 989178b

Powered by Codecov. Updated on successful CI builds.

ceedubs added a commit that referenced this pull request Jan 30, 2016
@ceedubs ceedubs merged commit 9f92106 into typelevel:master Jan 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants