-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Contravariant documentation page #859
Conversation
Appreciate any input/corrections :) |
layout: default | ||
title: "Contravariant" | ||
section: "typeclasses" | ||
source: "https://github.com/non/cats/blob/master/core/src/main/scala/cats/functor/Contravariant.scala" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should switch from non
to typelevel
. We probably have the same mistake in lots of docs. We could probably just give relative paths here and use site-wide config for the base source URL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange, but currently useful links
section, with those source
links is hidden...
I think this issue and all links should be fixed in another pr. I'll take care of that.
I made a few minor comments, but this is great. Thanks, @vpavkin! |
Current coverage is
|
@ceedubs I'm not a native speaker, thank you for covering my back here! :) |
👍 |
Thanks so much! 👍 |
Add Contravariant documentation page
Preview http://vpavkin.github.io/cats/tut/contravariant.html