Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Call.loop @tailrec optimized. #923

Merged
merged 1 commit into from
Mar 16, 2016
Merged

Conversation

TomasMikula
Copy link
Contributor

Ensure Call.loop is @tailrec optimized. Elegance of the code suffered a bit, but I guess it's worth it?

The fact that @tailrec could not be put on loop as it was actually seems like a Scala bug, because the second call to loop is not a recursive call.

@codecov-io
Copy link

Current coverage is 88.98%

Merging #923 into master will increase coverage by +0.04% as of 819aa1f

@@            master    #923   diff @@
======================================
  Files          179     179       
  Stmts         2125    2125       
  Branches        42      42       
  Methods          0       0       
======================================
+ Hit           1890    1891     +1
  Partial          0       0       
+ Missed         235     234     -1

Review entire Coverage Diff as of 819aa1f

Powered by Codecov. Updated on successful CI builds.

@ceedubs
Copy link
Contributor

ceedubs commented Mar 13, 2016

👍. Ensuring @tailrec optimization seems like a good enough reason to make this minor sacrifice in code cleanliness.

@stew
Copy link
Contributor

stew commented Mar 16, 2016

👍

stew added a commit that referenced this pull request Mar 16, 2016
@stew stew merged commit 3f48848 into typelevel:master Mar 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants