Switch to use nodeJsEnv as default jsEnv to build scala.js #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, scala.js compiler uses `Rhino` as the js environment. But it usually requires a lot of memory and often lead to OOM. This PR replace the default to a node.js one that should be much faster and slimer.
ngbinh
force-pushed
the
scala.js-uses-nodejs
branch
from
5784a6f
to
dcc292f
Compare
Current coverage is
|
|
Thanks @ngbinh! Forgive my ignorance about scala.js: will this affect users Cats scala.js users, or does this only change the environment that our JS tests run in? |
The batchMode should help reduce the memory requirement to compile scala.js code as per scala-js/scala-js#1788 (comment) Implementation details: botBuild is a sbt setting that will be turned on on travisCi so that it will not interfere with local dev experience.
|
@ceedubs it shouldn't affect scala.js Cats users. It only used a different jsEnv. Scala.js libraries are actually compiled in |
|
Hurrah! 👍 |
|
💯 |
This was referenced Mar 28, 2016
Merged
|
Hmm any ideas why this build is still failing? #941 |
|
commented in #941. There is one more thing I'd like to do is upgrading scala.js plugin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, scala.js compiler uses
Rhinoas the js environment. But itusually requires a lot of memory and often lead to OOM. This PR replace
the default to a node.js one that should be much faster and slimer.