Disable scaladoc during packaging for scala 2.10

[mikejcurry]

My previous PR #958 missed the fact that the shell script which executes the build runs a publish as the final command. In the case of Pull Requests this is a publishLocal. On master it runs something different, which appears to publish snapshots.

As such, the previous PR allowed #898 to pass the site generation process, but it failed during the publish stage - the last command executed during the pull request build process.

Sorry about that.

This one disables the scaladoc packaging phase during publish for 2.10, which hopefully finally allows #898 to pass.

I tested publishLocal and it passes fine on 2.10 now albeit with docs not generated. 2.11 still generates scaladoc during the publish phase.

[codecov-io]

Current coverage is 89.78%

Merging #959 into master will not affect coverage as of 34abc24

@@            master    #959   diff @@
======================================
  Files          180     180       
  Stmts         2144    2144       
  Branches        42      42       
  Methods          0       0       
======================================
  Hit           1925    1925       
  Partial          0       0       
  Missed         219     219       

Review entire Coverage Diff as of 34abc24

Powered by Codecov. Updated on successful CI builds.

[ceedubs]

👍 thanks!

[mikejcurry]

Anybody else happy to give this a thumbs up?

It is not a perfect solution, and there might be a better way to disable scaladoc for 2.10 on these projects but it allows scaladoc to be written for more type classes, with Comonad being an example in point.

[milessabin]

👍